[ty] Add more tests for NamedTuples#17975
Merged
sharkdp merged 2 commits intoastral-sh:mainfrom May 10, 2025
Merged
Conversation
abhijeetbodas2001
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
Contributor
Author
Contributor
|
This comment was marked as outdated.
This comment was marked as outdated.
sharkdp
reviewed
May 9, 2025
sharkdp
reviewed
May 9, 2025
Comment on lines
8
to
17
| ### Definition | ||
|
|
||
| ```py | ||
| from typing import NamedTuple | ||
|
|
||
| class Location(NamedTuple): | ||
| altitude: float = 0.0 | ||
| latitude: float # TODO: this should be an error. Fields without default values cannot come after fields with. | ||
| longitude: float | ||
| ``` |
Contributor
There was a problem hiding this comment.
Can we move this test somewhere below? I'd like to have the "Basics" test on top.
Contributor
Author
There was a problem hiding this comment.
Sure, done!
Contributor
Author
|
Thanks David. I've addressed both your comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add more tests and TODOs for
NamedTuplesupport, based on the typing spec: https://typing.python.org/en/latest/spec/namedtuples.htmlTest Plan
This PR adds new tests.